feat: add testmon support to detect when tests need to be rerun#1056
Merged
feat: add testmon support to detect when tests need to be rerun#1056
Conversation
Signed-off-by: Terry Kong <terryk@nvidia.com>
github-actions
bot
added
the
documentation
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
chtruong814
approved these changes
Sep 4, 2025
wangshangsam
pushed a commit
that referenced
this pull request
Sep 4, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Shang Wang <samshang.wang@mail.utoronto.ca>
guyueh1
pushed a commit
to guyueh1/NeMo-RL
that referenced
this pull request
Sep 15, 2025
…IA-NeMo#1056) Signed-off-by: Terry Kong <terryk@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
…IA-NeMo#1056) Signed-off-by: Terry Kong <terryk@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To encourage more local testing to avoid discovering issues in the merge-queue pipeline, this PR introduces
pytest-testmonto only re-run tests affected by a code change.By itself
pytest-testmondoesn't help us rerun changes to@ray.remotedecorated actors/tasks so this PR introduces a plugin to crudely detect that a test should be rerun because it depended on a module with@ray.remoteby looking at the mtime.The plugin is not perfect and still requires users to know that a test needs to be rerun because say, a static asset like a YAML, was changed that affects the tests, but this at least will make it easier to rerun.